395544 - Remove unused strings in preferences.properties

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix

We'll probably lose a few more if/when we port bug 377784 (that being where Gavin noticed that pluginHelperNoneAvailable was unused), but this at least gives us a clear slate for that.

The big wad of password strings went to toolkit in bug 285158, as did downloadHelperNoneSelected (it's only used by #fileField).

pluginHelperNoneAvailable we haven't ever used, from the first bug 284144 landing

Despite the "#### Fonts" heading, the two language code format strings are used in the UI for setting intl.accept_languages (Advanced - General - choose languages in Firefox, never been in Thunderbird)

fontScalingResolutionFormat went away in bug 326329

Comment 1

[Magnus Melin [:mkmelin]]

Didn't try running with this, but setMasterPassword and changeMasterPassword look like they are still used at
<http://lxr.mozilla.org/seamonkey/source/mail/components/preferences/privacy.js#140>

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.2

Nice, another pattern to help me screw up (at least, I don't *think* I've seen the "set a label that will never be seen in the XUL, and then change it in the JS, unless someone kills the properties, in which case he'll see the XUL's string and not see what he did" pattern before).

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 280262 [details] [diff] [review]
Fix v.2

Looks good. r=[e-mail]

Comment 4

[Phil Ringnalda (:philor)]

mail/locales/en-US/chrome/messenger/preferences/preferences.properties 1.4