UseUserPrefFile should check that user.js exists

RESOLVED FIXED

Status

()

Core
Preferences: Backend
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Robert Sayre, Assigned: Robert Sayre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.10 KB, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: superreview+
Benjamin Smedberg
: approval1.9+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
We try to open the file as an input stream before checking that it exists
(Assignee)

Comment 1

11 years ago
Created attachment 280295 [details] [diff] [review]
call exists()
Assignee: nobody → sayrer
Status: NEW → ASSIGNED
Attachment #280295 - Flags: superreview?(benjamin)
Attachment #280295 - Flags: review?(benjamin)
(Assignee)

Comment 2

11 years ago
hmm, NS_ERROR_FILE_NOT_FOUND is better, wonder why I didn't see that when I looked in LXR.

Comment 3

11 years ago
Comment on attachment 280295 [details] [diff] [review]
call exists()

r=me with your nit
Attachment #280295 - Flags: superreview?(benjamin)
Attachment #280295 - Flags: superreview+
Attachment #280295 - Flags: review?(benjamin)
Attachment #280295 - Flags: review+
Attachment #280295 - Flags: approval1.9+
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.