395644 - postface plugin names with "(in Firefox)" in Applications prefpane actions dropdown menu

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

faaborg's review in bug 377784, comment 45 says that we should postface plugin names with the text "(in Firefox)" to make it clearer that they open inside Firefox.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: adds postface

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: uses brandShortName

Gavin pointed out on IRC that we should be using brandShortName instead of hardcoding the name of the application in the pluginName property.  Here's a patch that does that.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 280838 [details] [diff] [review]
patch v2: uses brandShortName

Requesting approval for M9 for this low-risk, well-understood polish fix.  The bulk of the patch is just name changes (_bundle -> _prefBundle to make room for _brandBundle).  Otherwise very little has changed.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v3: resolves trivial conflicts with bug 395636

The patch for bug 395636 removed some code containing strings that this patch renames.  Here's a patch that resolves the conflict now that the patch for bug 395636 has been checked in.  This is the version of the patch I'll check in.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/preferences.xul;
/cvsroot/mozilla/browser/components/preferences/preferences.xul,v  <--  preferences.xul
new revision: 1.14; previous revision: 1.13
done
Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.6; previous revision: 1.5
done
Checking in browser/locales/en-US/chrome/browser/preferences/preferences.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v  <--  preferences.properties
new revision: 1.16; previous revision: 1.15
done