Closed Bug 395644 Opened 14 years ago Closed 14 years ago
postface plugin names with "(in Firefox)" in Applications prefpane actions dropdown menu
7.79 KB, patch
|Details | Diff | Splinter Review|
faaborg's review in bug 377784, comment 45 says that we should postface plugin names with the text "(in Firefox)" to make it clearer that they open inside Firefox.
Assignee: nobody → myk
Priority: -- → P2
Target Milestone: --- → Firefox 3 M9
Gavin pointed out on IRC that we should be using brandShortName instead of hardcoding the name of the application in the pluginName property. Here's a patch that does that.
Attachment #280838 - Flags: review?(gavin.sharp) → review+
Comment on attachment 280838 [details] [diff] [review] patch v2: uses brandShortName Requesting approval for M9 for this low-risk, well-understood polish fix. The bulk of the patch is just name changes (_bundle -> _prefBundle to make room for _brandBundle). Otherwise very little has changed.
Attachment #280838 - Flags: approval1.9?
Attachment #280838 - Flags: approval1.9? → approval1.9+
The patch for bug 395636 removed some code containing strings that this patch renames. Here's a patch that resolves the conflict now that the patch for bug 395636 has been checked in. This is the version of the patch I'll check in.
Attachment #280838 - Attachment is obsolete: true
Checking in browser/components/preferences/preferences.xul; /cvsroot/mozilla/browser/components/preferences/preferences.xul,v <-- preferences.xul new revision: 1.14; previous revision: 1.13 done Checking in browser/components/preferences/applications.js; /cvsroot/mozilla/browser/components/preferences/applications.js,v <-- applications.js new revision: 1.6; previous revision: 1.5 done Checking in browser/locales/en-US/chrome/browser/preferences/preferences.properties; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v <-- preferences.properties new revision: 1.16; previous revision: 1.15 done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.