395694 - Since Larry landing the url bar is larger on ssl sites

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Dave Townsend [:mossop]]

Since Larry landed I've noticed the location bar changing height depending on the webpage I view.

Specifically on an ssl site that does not have a webfeed the location bar is 1 pixel smaller than it should be.

On an ssl site with a feed the feed icon appears to keep the location bar at an appropriate height.

On a non-ssl site regardless of feed the bar appears to be the right height.

My toolbar is as standard except search and resizer removed and icons set small. With icons on large I do not see the problem.

Switching between tabs makes the location bar shift in size causing the entire content area to jump up and down which is real irritating.

Looking with DOMi, it seems that #feed-button changes between 15.15px when there is no feed and 16px when there is a feed.

I've tested and forcing a height of 16px on the #urlbar-icons fixes the problem.

Comment 1

[Johnathan Nightingale [:johnath]]

Attachment: Need one more pixel of padding

Yeah, I can see this behaviour on mac if I move to small icons, large icons seem to "prop it up" and hide the problem.  Attaching a little 1-line patch that fixes how the margins are handled by Larry, but I haven't tested it on Windows yet.

Comment 2

[Brian Polidoro]

I've seen the opposite problem on Windows in a certain situation.  Bug 395244

Comment 3

[Dave Townsend [:mossop]]

Well this patch does solve the issue, the url bar remains the same height at all times. However it introduces another problem. With it the favicon shifts down by 1 pixel on secure sites compared to non-secure sites (regardless of feed icon).

Comment 4

[Johnathan Nightingale [:johnath]]

Attachment: Add padding in the right places this time.

Mossop - this is what I should have done before hand, though it doubles the size of the patch.  :)  I think this one should work for you?

Comment 5

[Dave Townsend [:mossop]]

With the new larry landing this behaviour has changed. Now the url bar is 1 pixel too large on all ssl sites (regardless of feed icon and toolbar size). It extends 1 pixel above the top of the star icon.

Comment 6

[Johnathan Nightingale [:johnath]]

Attachment: Patch against updated trunk

Applies against current trunk and removes the pixel of errant bottom padding on mac.  I've checked this against a normal profile as well as dave's minimal setup, but would like his explicit yes before landing, to make sure I get it right this time.

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 282296 [details] [diff] [review]
Patch against updated trunk

r=me

There is still one minor difference that Im not so interested in, on an ssl site the autocomplete drop down arrow is about a pixel or two further left, but thats barely noticeable

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/pinstripe/browser/browser.css 	1.81

Comment 9

[Dave Townsend [:mossop]]

This has been backed out as part of bug 383183 to investigate the Tp regression talos is showing

Comment 10

[Johnathan Nightingale [:johnath]]

Fixed with the last relanding of bug 383183, confirmed by Dave.