395731 - make "Save File" action appear after "Choose Application..." in Applications prefpane

Status: VERIFIED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

faaborg's review in bug 377784, comment 45 says that for types you can save to disk, the "Save to Disk" item should appear at the end of the list, after "Choose Application...".

But in bug 377784, comment 46, mconnor says "Hmm, I'm not sure that's right.  I save things to disk quite a lot. :)"

After which faaborg responds in bug 377784, comment 48: "we need a way to support undo if you select "save to disk" in the content handling dialog and check "always do this."  Save to disk items should be listed after items that are associated with a particular application."

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

>mconnor says "Hmm, I'm not sure that's right.  I
>save things to disk quite a lot. :)"

Mconnor: I'm not sure I follow your concern, these lists aren't expected to
contain that many items.  Would you rather have Save to Disk listed first? 
Either way, I just don't want it grouped into the set of applications/choose
application.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

mconnor, any additional thoughts on this?

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

There was another bug where we were considering changing "save to disk" to "download file" since some users don't have a mental model of a disk being inside their computer, and may think "but I don't have a disk."  If we make that change, this needs to be changed as well.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #3)
> There was another bug where we were considering changing "save to disk" to
> "download file" since some users don't have a mental model of a disk being
> inside their computer, and may think "but I don't have a disk."  If we make
> that change, this needs to be changed as well.

That was bug 301972, and it has been checked in (as "Save File", per beltzner).  I filed bug 396989 on changing "Save to Disk" to "Save File" in the Applications prefpane.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Requesting wanted-1.9 for this Applications prefpane polish fix.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

My feeling is that it makes sense to group "Choose Application..." together with the the list of applications in the dropdown menu, since "Choose Application..." supplements that list, so "Save to Disk" (now "Save File", per bug 396989) makes the most sense either after "Choose Application..." or before the list of applications but not between the two.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

I agree

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: moves "Save File" after "Choose Application..."

Here's a patch that moves "Save File" to the end of the list of actions.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 282682 [details] [diff] [review]
patch v1: moves "Save File" after "Choose Application..."

Requesting approval for this trivial fix that simply reorders two independent chunks of code.

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 282682 [details] [diff] [review]
patch v1: moves "Save File" after "Choose Application..."

good for now, not sure if Save File should be first though.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #10)
> (From update of attachment 282682 [details] [diff] [review])
> good for now, not sure if Save File should be first though.

Yup, let's continue to ponder and then file another bug to make that change if we determine it makes the most sense.

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.12; previous revision: 1.11
done

Comment 12

[Tony Chung [:tchung]]

I still see "Save File" appear before the "Use Other..." action.  is this correct?

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050704 Minefield/3.0pre

Comment 13

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #12)
> I still see "Save File" appear before the "Use Other..." action.  is this
> correct?

The ordering was changed again in bug 402252, so there isn't really anything to verify here I guess.

Comment 14

[Tony Chung [:tchung]]

based on https://bugzilla.mozilla.org/show_bug.cgi?id=402252#c24, i'll mark this bug verified.