395781 - [Proto] Event Dialog: Hyperlinks don't provide visual feedback (focus rectangle) if selected with Tab key

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Christian Jansen]

1. Open Event Dialog
2. Add Link
3. Click in "Title"
4. Hit TAB until focus moves to "Link"
5. Hit TAB once again


Result:
Hyperlinks are ignored while traveling with TAB through the dialog

Expected Result:
Include Links (Attendees, Timezone, Custom Alarm, Custom Recurrence, Link) to tabbing-order

Comment 1

[Stefan Sitter [:ssitter]]

Works for me using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070910 Calendar/0.7pre.

Using TAB key you can access all the hyperlinks and execute them using RETURN key.

But the hyperlinks don't provide any visual feedback (e.g. focus rectangle) that they are selected. This should be fixed.

Comment 2

[Christian Jansen]

Agreed. I did not recognized that.

Comment 3

[Stefan Sitter [:ssitter]]

The problems seems that sun-calendar-event-dialog.css overwrites the toolkit style rules for .text-link <http://lxr.mozilla.org/seamonkey/source/calendar/prototypes/wcap/sun-calendar-event-dialog.css#45>

If I remove the rules I get the focus rectangle and the link is colored red instead of blue as specified in <http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/global/formatting.css#206> and <http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/global/formatting.css#202> because it's included by global.css.

Comment 4

[Stefan Sitter [:ssitter]]

Attachment: rev0 - use toolkit styling for text-link

Comment 5

[Stefan Sitter [:ssitter]]

Attachment: rev0 - screenshot for ui-review

This is how the dialog looks like using the winstripe theme. I can't test on Mac therefore I can't provide a screenshot for this.

Comment 6

[Christian Jansen]

Thanks for the patch. I've tested it on Mac and the problem still occurs, but this seems to be general problem (the Add-Ons-Dialog has the same problem).

Please make sure that visited links stay blue. ui+ with that. Please note that I'll be on a conference next week. I'm not sure how frequently I can check e-mails.

Comment 7

[Stefan Sitter [:ssitter]]

Comment on attachment 280905 [details] [diff] [review]
rev0 - use toolkit styling for text-link

Marking obsolete according to Comment #6

Comment 8

[Christian Jansen]

Now I had the chance to take look at the Windows version. Hyperlinks are truly displayed red if selected by tab, I did not know that. Sorry, for the confusion. The patch is ok.

Comment 9

[Martin Schröder [:mschroeder]]

Comment on attachment 280905 [details] [diff] [review]
rev0 - use toolkit styling for text-link

per comment#8

Comment 10

[Martin Schröder [:mschroeder]]

Comment on attachment 280906 [details]
rev0 - screenshot for ui-review

per comment#8

Comment 11

[Michael Büttner (no reviews TFN)]

Comment on attachment 280905 [details] [diff] [review]
rev0 - use toolkit styling for text-link

r=mickey.

Comment 12

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 13

[Omar Bajraszewski]

Verified with lightning 2007092403