Closed
Bug 395925
Opened 17 years ago
Closed 17 years ago
revise entity reminder.due.label
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: sebo.moz, Assigned: cmtalbert)
References
()
Details
Attachments
(2 files)
1.55 KB,
patch
|
michael.buettner
:
review+
michael.buettner
:
ui-review+
|
Details | Diff | Splinter Review |
2.29 KB,
patch
|
Details | Diff | Splinter Review |
The entity reminder.due.label in sun-calendar-event-dialog.dtd (see URL, "When Reminder becomes Due") has been approved on IRC to be rather cryptic for native speakers. The following strings have been propsed on IRC: "Choose a Reminder Action" "When a Reminder Fires" The preference dialog uses: "When an alarm goes off:"
Changing it to the "Choose a Reminder Action" since this is not as awkward sounding as "When a Reminder Becomes Due" and is a bit easier to translate. A little background...This issue came up because one of the localizers did not understand how to translate the original string, and I realized that the original string really wasn't that great for native english speakers either.
Assignee: nobody → ctalbert
Status: NEW → ASSIGNED
Attachment #280628 -
Flags: ui-review?(christian.jansen)
Attachment #280628 -
Flags: review?(michael.buettner)
Comment 2•17 years ago
|
||
Comment on attachment 280628 [details] [diff] [review] Changing the en-US string UI+ = Christian, thanks for the rewording :-)
Comment 3•17 years ago
|
||
Comment on attachment 280628 [details] [diff] [review] Changing the en-US string r=mickey
Attachment #280628 -
Flags: ui-review?(christian.jansen)
Attachment #280628 -
Flags: ui-review+
Attachment #280628 -
Flags: review?(michael.buettner)
Attachment #280628 -
Flags: review+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 4•17 years ago
|
||
Is the checkin-needed before 0.7 or after 0.7? In the latter case I suggest to set the whiteboard to e.g. [checkin-needed after 0.7].
Comment 5•17 years ago
|
||
The latter is intended, I changed the whiteboard accordingly.
Keywords: checkin-needed
Whiteboard: [checkin-needed after 0.7]
Comment 6•17 years ago
|
||
patch checked in on trunk and MOZILLA_1_8_BRANCH -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Whiteboard: [checkin-needed after 0.7]
Target Milestone: --- → 0.8
Comment 7•17 years ago
|
||
Martin reminded me that we should always rename the entity when changing the meaning of a string. This add-on patch takes care of that.
Comment 8•17 years ago
|
||
add-on patch checked in on trunk and MOZILLA_1_8_BRANCH
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•