native comboboxes draw outside their frame

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 280812 [details] [diff] [review]
fix v1.0

Native comboboxes draw outside their frame. This causes bug 391479.
Flags: blocking1.9+
Attachment #280812 - Flags: review?(cbarrett)
Comment on attachment 280812 [details] [diff] [review]
fix v1.0


>+      // popup buttons draw outside their frame by 1 pixel on each side and two on the bottom
>+      drawFrame.size.width -= 2;
>+      drawFrame.origin.x += 1;
>+      drawFrame.size.height -= NATIVE_PUSH_BUTTON_HEIGHT_DIFF;

Should use a constant, NATIVE_PUSH_BUTTON_WIDTH_DIFF = 2?

>       // We need to shift the text up a single pixel. For native form control drawing,
>       // the borders need not actually reflect the size of the drawn border.
>-      aResult->SizeTo(kAquaDropdownLeftBorder, 1, kAquaDropdownRightBorder, 1);
>+      aResult->SizeTo(kAquaDropdownLeftBorder, 2, kAquaDropdownRightBorder, 2);
>       break;

Is that comment still accurate? If not, change it.
Attachment #280812 - Flags: review?(cbarrett) → review-
(Assignee)

Comment 2

11 years ago
Comment on attachment 280812 [details] [diff] [review]
fix v1.0

I don't want to use a constant/macro, I don't think it really makes things clearer.

That comment is inaccurate now, I'll remove it on checkin.
Alright. The comment above those numbers is pretty clear.

r=me.
Attachment #280812 - Flags: review- → review+
(Assignee)

Updated

11 years ago
Attachment #280812 - Flags: superreview?(roc)
Attachment #280812 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 4

11 years ago
landed on trunk
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Blocks: 391479
You need to log in before you can comment on or make changes to this bug.