Created attachment 280812 [details] [diff] [review] fix v1.0 Native comboboxes draw outside their frame. This causes bug 391479.
Attachment #280812 - Flags: review?(cbarrett)
Comment on attachment 280812 [details] [diff] [review] fix v1.0 >+ // popup buttons draw outside their frame by 1 pixel on each side and two on the bottom >+ drawFrame.size.width -= 2; >+ drawFrame.origin.x += 1; >+ drawFrame.size.height -= NATIVE_PUSH_BUTTON_HEIGHT_DIFF; Should use a constant, NATIVE_PUSH_BUTTON_WIDTH_DIFF = 2? > // We need to shift the text up a single pixel. For native form control drawing, > // the borders need not actually reflect the size of the drawn border. >- aResult->SizeTo(kAquaDropdownLeftBorder, 1, kAquaDropdownRightBorder, 1); >+ aResult->SizeTo(kAquaDropdownLeftBorder, 2, kAquaDropdownRightBorder, 2); > break; Is that comment still accurate? If not, change it.
Attachment #280812 - Flags: review?(cbarrett) → review-
Comment on attachment 280812 [details] [diff] [review] fix v1.0 I don't want to use a constant/macro, I don't think it really makes things clearer. That comment is inaccurate now, I'll remove it on checkin.
Alright. The comment above those numbers is pretty clear. r=me.
Attachment #280812 - Flags: superreview?(roc) → superreview+
landed on trunk
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.