Closed Bug 396159 Opened 17 years ago Closed 17 years ago

Unused entity lightning.context.deleteitem.accesskey

Categories

(Calendar :: Lightning Only, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: milupo, Assigned: ssitter)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; hsb-DE; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4
Build Identifier: 2007091204

A superfluous entity seems to exist in calendar.dtd. It concerns the entity

 <!ENTITY calendar.context.deleteitem.accesskey "l">

which seems to belong to

<!ENTITY calendar.context.deleteitem.label "Delete Item">

in the same file. But the mentioned accesskey entity is not used for the mentioned label entity but it is used the entity

<!ENTITY lightning.context.deleteitem.accesskey  "D">

from the file lightning.dtd instead.



Reproducible: Always

Steps to Reproduce:
1. Right click in a Calendar view
2. There is the context menu entry Delete item
3. Set the value of <!ENTITY lightning.context.deleteitem.accesskey  "D"> in calendar to a letter that is n o t contained in the expression "Delete item"

Actual Results:  
There should be an error showing the wrong accesskey in parentheses
But there won't be an error because the above mentioned accesskey entity is not used but the entity <!ENTITY lightning.context.deleteitem.accesskey  "D">

Expected Results:  
I think one of the 2 accesskey entities is superfluous and can be deleted

Attention: This bug appears only if the accesskey of <!ENTITY lightning.context.deleteitem.accesskey  "D"> is wrong in the expression "Delete item" of entity <!ENTITY calendar.context.deleteitem.label "Delete Item">. 
Normally it's thought that <!ENTITY calendar.context.deleteitem.accesskey "l"> should be changed but this will not have any effect.

In the English version both accesskey entities define letters that are contained in the expression "Delete item". Therefore the bug doesn't appear.
Taking. We'll fix this after 0.7 is out of the door. If you find more unused entities, please file bugs for them.
Assignee: nobody → bugzilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows ME → All
Hardware: PC → All
Whiteboard: post-0.7
Status: NEW → ASSIGNED
Summary: Seemingly superfluous entity → Unused entity calendar.context.deleteitem.accesskey
Attached patch fixSplinter Review
Assignee: bugzilla → ssitter
Attachment #288200 - Flags: review?(bugzilla)
Comment on attachment 288200 [details] [diff] [review]
fix

r=sipaq

Tell me, if you need me to get this checked in.
Attachment #288200 - Flags: review?(bugzilla) → review+
Keywords: checkin-needed
Whiteboard: post-0.7
Patch checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: Unused entity calendar.context.deleteitem.accesskey → Unused entity lightning.context.deleteitem.accesskey
Keywords: checkin-needed
Target Milestone: --- → 0.8
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.