396176 - Make change in viewSource() due to Bug 382074 backward compatible

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Philip Chee]

Bug 382074 introduced a new window parameter to viewSource() in the middle of existing window parameters.
<http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=viewSource.js&branch=&root=/cvsroot&subdir=mozilla/toolkit/components/viewsource/content&command=DIFF_FRAMESET&rev1=1.18&rev2=1.19>

This caused Bug 394475 which was fixed but only for the Error Console. This change affects the Console² extension and potentially other extensions that invoke view source. In order for these extensions to be backward compatible with older versions of Firefox I propose to move the new isForcedCharset parameter to the end of the parameter list. Extensions that pass only four parameters to viewSource.xul with the line number as the fourth parameter will continue to work as usual.

Comment 1

[Philip Chee]

Attachment: Patch v1.0

Patch for review.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 280895 [details] [diff] [review]
Patch v1.0

fine with me.

Comment 4

[Reed Loden [:reed]]

Checking in toolkit/components/console/content/consoleBindings.xml;
/cvsroot/mozilla/toolkit/components/console/content/consoleBindings.xml,v  <--  consoleBindings.xml
new revision: 1.21; previous revision: 1.20
done
Checking in toolkit/components/viewsource/content/viewSource.js;
/cvsroot/mozilla/toolkit/components/viewsource/content/viewSource.js,v  <--  viewSource.js
new revision: 1.21; previous revision: 1.20
done
Checking in toolkit/components/viewsource/content/viewSourceUtils.js;
/cvsroot/mozilla/toolkit/components/viewsource/content/viewSourceUtils.js,v  <--  viewSourceUtils.js
new revision: 1.7; previous revision: 1.6
done