XP build system fixes: arbitrary zlib and windows-debug warnings

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 280919 [details] [diff] [review]
zlib and windows linkage fixes, rev. 1

This patches fixes two independent issues:

1) Allow the build system to include and link against an arbitrary zlib. This will help the Mozilla build to use our in-tree zlib: it will also help builders on windows who download a zlib off the interweb, because there isn't a builtin zlib on Windows.

2) Fixes Windows linkage rules so that you can link against the static CRT or the dynamic CRT, and so that avmshell.exe has the proper suffix. It also disables compiler warning C4291: http://msdn2.microsoft.com/en-us/library/cxdxz3x6(VS.80).aspx This warning only appears in debug builds which have exceptions enabled.
Attachment #280919 - Flags: review?(treilly)
(Assignee)

Comment 1

10 years ago
Created attachment 281849 [details] [diff] [review]
Allow building MMgc as a sharedlib, rev. 2

This patch subsumes the first: in addition to the zlib/windows fixes, it fixes a windows dependency-generation error and allows one to optionally build MMGC as a shared library.

I have this as a stack of patches, so I can provide them separate if that would be easier to review.
Attachment #280919 - Attachment is obsolete: true
Attachment #281849 - Flags: review?
Attachment #280919 - Flags: review?(treilly)
(Assignee)

Updated

10 years ago
Attachment #281849 - Flags: review? → review?(treilly)

Comment 2

10 years ago
Comment on attachment 281849 [details] [diff] [review]
Allow building MMgc as a sharedlib, rev. 2

Looks fine, wish the public API set was smaller, stupid C++ !
Attachment #281849 - Flags: review?(treilly) → review+
(Assignee)

Comment 3

10 years ago
Pushed to tamarin-central, changeset 167/08322d1de212
Assignee: nobody → benjamin
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.