396229 - Bookmarks manager - undo/redo broken after drag up in one folder

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091412 Minefield/3.0a8pre ID:2007091412

repro:
 create a bookmarksfolder X with bookmarks A B C D
 open Bookmarks Manager
 open folder X and drag D to the top (D A B C)
 got to [Edit]

result:
[Undo] is grayed out, you can't undo the drag
[Redo] is grayed out

expected:
[Undo] to be available
--------------------------------------------------

repro continue:
 close Bookmarks Manager
 open Bookmarks Manager
 got to [Edit]
 [Undo] is available, click it.
 
result:
The order is incorrectly undone, it's now A B D C
[Redo] is grayed out

expected:
[Redo] to be available after [Undo] is clicked.
[Undo] to be available after [Undo] is clicked (we only did 1 thing).
--------------------------------------------------

repro continue:
 close Bookmarks Manager
 open Bookmarks Manager
 got to [Edit]
 [Undo] is grayed out
 [Redo] is available, click it

result:
The order is set to D A B C (correct)

extpected:
[Undo] to be available after [Redo] is clicked
[Redo] to be grayed out after [Redo] is clicked (we only did 1 thing).

Comment 1

[Peter van der Woude [:Peter6]]

testcase 2 where undo/redo simply fails to reorder at all

repro:
 close and open Firefox
 create a bookmarksfolder X with bookmarks A B C D
 open Bookmarks Manager
 open folder X and drag D up 1 position (A B D C)
 got to [Edit]
 from here repeat al steps of comment #0

result:
neither [Undo] or [Redo] will change the order

Comment 2

[Al Billings [:abillings - ex-MoCo]]

Need to add litmus cases around these areas.

Comment 3

[Marco Bonardo [:mak]]

this wfm for me, please reopen if i missed some step
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081219 Minefield/3.2a1pre

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv