396284 - Crash on shutdown [@ RtlpWaitForCriticalSection ] from [@ ns4xPluginInstance::Stop]

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Brian Polidoro]

Attachment: crash stack

I've recently started seeing crashes on shutdown.  After some investigation here's what I've found.  

The crash goes away when I disable Adblock Plus 7.5.1.  So that's involved as far as I can tell.  This occurs even with no filters defined.

The crash occurs when I'm logged into Classic Yahoo Mail.  

I also have Yahoo Messenger so the Yahoo Application State Plugin is installed.  The crash goes away when I disable that plugin from the addons dialog.  And it doesn't seem to come back by just re-enabling the plugin and logging in.  It came back after I deleted a message.  So I guess that does something with the plugin.  But then just restoring my session with YM and closing the browser crashes.  

This is similar to bug 395412 but the stacks are different.  And that crash doesn't occur at shutdown.  

From the crash reports this signature spiked starting with 9/6 nightly.  And bug 393845 landed during 9/5.  The crash reports that I looked at with that signature before 9/6 had different stacks other than the signature.  So I guess those reports are from another problem.  

My yahoo messenger info:
Yahoo Messenger 8.1.0.401
My Yahoo Module 8.0.0.1

Attached is bp-950237b5-63a4-11dc-83d2-001a4bd46e84 crash report.
Crash Reports:
http://crash-stats.mozilla.com/report/list?range_unit=weeks&version=Firefox%3A3.0a8pre&range_value=2&signature=RtlpWaitForCriticalSection

Phew I hope I've got it all.

Comment 1

[Mats Palmgren (inactive)]

Bug 393845 and bug 392125 touched plugin code in that interval.

Comment 2

[Michael Wu [:mwu]]

Bug 392125 is Java plugin specific and doesn't touch code related to where this is crashing, as far as I can tell. Bug 393845 seems be it.. it affects the stop code.

Comment 3

[Peter van der Woude [:Peter6]]

this should be fixed by the backout of Bug 393845

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Ok, marking fixed per previous comment.