396297 - [Proto] Event/Task description in not saved when exiting by closing the new edit window

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[klint]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 ThunderBrowse/3.1.4.159265 ID:2007072817 Lightning build 20070915

When editing an event or a task in the new edit dialog, the description is not saved if you close the edit dialog by using the "close window" button and choose to save.

Reproducible: Always

Steps to Reproduce:
1.Edit an event or task (whatever catalog) by double-clicking or right-clicking/"Edit event".
2.Update the description field and any other field
3.Click on the "close window" button on the top right
4.Choose "save" when asked for confirmation
Actual Results:  
The description updated value is not saved (all other fields seem ok though)

Expected Results:  
The description updated value should be saved (as any other updated field)

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I Can confirm. I think this should block the release since it means dataloss.

Comment 2

[Stefan Sitter [:ssitter]]

This seems to be caused by the following code place: <http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/prototypes/wcap/sun-calendar-event-dialog.js&rev=1.42&mark=211-217#203>

Upon cancel the new description is replaced with the old description before saving.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: set back to new value

After passing the old description to the text field we need to set it back to the new description. Otherwise onCommandSave() reads and stored the old value.

Comment 4

[Michael Büttner (no reviews TFN)]

Comment on attachment 281644 [details] [diff] [review]
set back to new value

>+    setElementValue("item-description", newItem.getProperty("DESCRIPTION"));
I was kicking myself for not catching this when I initially wrote this. But, yes, this is absolutely correct -> r=mickey. Thanks, Stefan.

Comment 5

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 6

[Andreas Treumann]

Checked in lightning 2008042719 ans Sunbird 20080427 -> VERIFIED.