Closed
Bug 396336
Opened 15 years ago
Closed 15 years ago
header of xul:list is not accessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
Details
Attachments
(1 file)
18.57 KB,
patch
|
evan.yan
:
review+
enndeakin
:
review+
neil
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
1) move common code from nsTreeAccessible.cpp to nsSelectAccessible.cpp that is shared by xul:listbox and xul:tree 2) make xul:listcols/listcol unaccessible (now they have accessible of xul:listbox) 3) make xul:head/xul:header accessible
Attachment #281076 -
Flags: review?(aaronleventhal)
Assignee | ||
Updated•15 years ago
|
Attachment #281076 -
Flags: review?(enndeakin)
Updated•15 years ago
|
Attachment #281076 -
Flags: review?(enndeakin) → review+
Assignee | ||
Updated•15 years ago
|
Attachment #281076 -
Flags: superreview?(neil)
Updated•15 years ago
|
Attachment #281076 -
Flags: superreview?(neil) → superreview+
Comment 1•15 years ago
|
||
Comment on attachment 281076 [details] [diff] [review] patch Nit: Could you change captalization of nsXULColumnitemAccessible to nsXULColumnItemAccessible ? Does this affect bug 365973?
Attachment #281076 -
Flags: review?(aaronleventhal) → review?(Evan.Yan)
Assignee | ||
Comment 2•15 years ago
|
||
(In reply to comment #1) > (From update of attachment 281076 [details] [diff] [review]) > Nit: Could you change captalization of nsXULColumnitemAccessible to > nsXULColumnItemAccessible ? > > Does this affect bug 365973? > Not sure, but I guess no. If I get right then bug 365973 requires nsIAccessibleTable interface on xul:listbox.
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2) > (In reply to comment #1) > > (From update of attachment 281076 [details] [diff] [review] [details]) > > Nit: Could you change captalization of nsXULColumnitemAccessible to > > nsXULColumnItemAccessible ? Sure. I like it more too.
Attachment #281076 -
Flags: review?(Evan.Yan) → review+
Assignee | ||
Updated•15 years ago
|
Attachment #281076 -
Flags: approval1.9?
Updated•15 years ago
|
Attachment #281076 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 4•15 years ago
|
||
checked in with nsXULColumnitemAccessible -> nsXULColumnItemAccessible change
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•