396345 - Unable to maximize window

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Dave Townsend [:mossop]]

If I maximize the firefox window it ends up a bit short, about a status-bar height shorter than it should be. Additionally trying to resize is weird. Resizing from the resizer it appears that the bottom of the window follows the pointer just about a status-bar height above the pointer.

Also as I resize quickly the pill and title bar text doesn't redraw properly.

This is a regression since the build from the 15th.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091604 Minefield/3.0a8pre ID:2007091604

Comment 1

[Dave Townsend [:mossop]]

Regression range: http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1189853880&maxdate=1189940238

Guessing on bug 218214

Comment 2

[Josh Aas]

Yeah, I bet my patch did cause this. However, I don't think my patch is wrong. I think there is other stuff depending on the bad behavior that was there before my patch. Looking into it.

Comment 3

[Josh Aas]

Attachment: fix v1.0

As for the visual corruption, our efforts at not doing nested resizes were failing because we were calling Gecko's ::Resize during a native Cocoa resize. We only need to report the native resize, not do another one at the same time (especially not when we muck with the coordinates).

Comment 4

[Josh Aas]

Attachment: fix v1.1

read the wrong type for mGeckoWindow, no need to cast and we should null check

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 281097 [details] [diff] [review]
fix v1.1

> nsCocoaWindow::ReportSizeEvent()
> {
>+  NSRect windowFrame = [mWindow contentRectForFrameRect:[mWindow frame]];
>+  mBounds.width  = (nscoord)windowFrame.size.width;
>+  mBounds.height = (nscoord)windowFrame.size.height;

Nit: you have some trailing whitespace after height. Also I'd prefer you keep the static_cast that previously existed over the c-style cast, but that's just me.

Comment 6

[Josh Aas]

Attachment: fix v1.2

address ben's comments

Comment 7

[Josh Aas]

Attachment: fix v1.3

misinterpreted one of ben's comments

Comment 8

[Josh Aas]

Comment on attachment 281101 [details] [diff] [review]
fix v1.2

I guess Ben did mean to cast to nscoord...

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 281101 [details] [diff] [review]
fix v1.2

+  mBounds.width  = static_cast<nscoord>(windowFrame.size.width);
+  mBounds.height = static_cast<nscoord>(windowFrame.size.height);

Actually constructor casts are best here: nscoord(...)

Comment 10

[Josh Aas]

landed on trunk