396373 - don't make Quickdraw calls unless there is a Quickdraw plugin present

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

We shouldn't make Quickdraw calls unless there is a Quickdraw plugin present. Making QD calls boots our windows off the Quartz fast path. In theory not doing this should improve performance when QD plugins aren't present.

Comment 1

[Josh Aas]

Attachment: pre-fix v1.0 [checked in 2007-09-17 15:55]

This gets rid of QD stuff we never need to use. Once this cleanup lands I'll post a patch for the real fix, which is never calling ::SetPort unless we have a QD plugin present.

Comment 2

[Colin Barrett [:cbarrett]]

Comment on attachment 281110 [details] [diff] [review]
pre-fix v1.0 [checked in 2007-09-17 15:55]


>+  // This sets the current port to _savePort.
>+  // todo: Only do if a Quicktime plugin is present in the hierarchy!
>+  ::SetPort(NULL);

>+  ::SetPort(NULL);  // todo: only do if a quicktime plugin is present in the hierarchy!
>   [super lockFocus];

I think in both of these places you mean QuickDraw ;)

Other than that, r+. Why was that qd stuff even there in the first place? Ick.

Comment 3

[Josh Aas]

Yeah, I did mean quickdraw in those comments, thanks. The QD stuff I'm removing is left over from when our old gfx impl used it.

Comment 4

[Josh Aas]

pre-fix v1.0 checked in with colin's comments addressed

Comment 5

[Stuart Parmenter]

can this be marked fixed?

Comment 6

[Josh Aas]

No - I removed QD stuff we *never* need - the QD calls we need to make for the sake of QD plugins are still made all the time, whether or not QD plugins are present.

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 281110 [details] [diff] [review]
pre-fix v1.0 [checked in 2007-09-17 15:55]

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.

Comment 8

[Reed Loden [:reed]]

Comment on attachment 281110 [details] [diff] [review]
pre-fix v1.0 [checked in 2007-09-17 15:55]

This was landed by josh on 2007-09-17 15:55.

Comment 9

[Damon Sicore (:damons)]

Comment on attachment 281110 [details] [diff] [review]
pre-fix v1.0 [checked in 2007-09-17 15:55]

Reset approval flag to + as it was already checked in.

Comment 10

[Reyn Saunders]

I'm using Camino Version 2007102517 (1.5.3) and Console is still giving error message about QuickDraw. Look for a later build?

Comment 11

[Josh Aas]

Those warnings aren't going to stop, even if we fix this bug. They won't stop until users aren't using QD-based plugins, which is some time in the future still.

Comment 12

[Josh Aas]

Closing this out, we don't support the Quickdraw drawing model any more.