Closed
Bug 396387
Opened 18 years ago
Closed 18 years ago
Use the native GTK help arrow on CSS "cursor: help"
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: ventnor.bugzilla, Assigned: ventnor.bugzilla)
Details
(Keywords: polish)
Attachments
(1 file)
|
5.23 KB,
patch
|
roc
:
review+
roc
:
superreview+
roc
:
approval1.9+
|
Details | Diff | Splinter Review |
Currently for GTK, whenever an element defines the CSS cursor: help, Mozilla draws a custom help cursor that actually matches the Windows default. GTK actually provides its own cursor design for this situation, and I think we should use it.
Attachment #281130 -
Flags: superreview?(roc)
Attachment #281130 -
Flags: review?(roc)
Comment on attachment 281130 [details] [diff] [review]
Patch
Looks good, just one question: when was this cursor added to GTK?
Attachment #281130 -
Flags: superreview?(roc)
Attachment #281130 -
Flags: superreview+
Attachment #281130 -
Flags: review?(roc)
Attachment #281130 -
Flags: review+
Attachment #281130 -
Flags: approval1.9+
|
Assignee | |
Comment 2•18 years ago
|
||
It seems to have been there since the beginning of GTK 2, and after searching it seems it may have also been in GTK 1 at some point too.
Keywords: checkin-needed
|
||
Updated•18 years ago
|
Assignee: nobody → ventnor.bugzilla
|
||
Comment 3•18 years ago
|
||
Checking in widget/src/gtk2/nsGtkCursors.h;
/cvsroot/mozilla/widget/src/gtk2/nsGtkCursors.h,v <-- nsGtkCursors.h
new revision: 1.6; previous revision: 1.5
done
Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v <-- nsWindow.cpp
new revision: 1.226; previous revision: 1.225
done
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
You need to log in
before you can comment on or make changes to this bug.
Description
•