39640 - [regression]The new GB2312GL converter missed fonts

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[yueheng.xu]

There are some run-time error for this newly checked-in converter. In the test 
page, many GB characters are missing fonts. It is because the loop counter mis-
calculation in line 114:

  iSrcLength += 2;

The aSrcLength is counted in units of unicode and above line should be:

   iSrcLength++;

A fix is under review now.

Comment 1

[Frank Tang]

yueheng.xu- Thank you for fixing this bug quickly. In the future, please send 
use code that you have tested and see correct result before submission.

Comment 2

[leger]

Putting on [nsbeta2+][6/01] radar.  This work must be done by 06/01 or we may 
pull this for PR2.

Comment 3

[yueheng.xu]

A tested and my peer reviewed fix has already submitted to ftang for review a 
week or two ago.

Comment 4

[yueheng.xu]

Attachment: diff of intl/uconv/ucvcn/gbku.h

Comment 5

[yueheng.xu]

Attachment: diff for intl/uconv/ucvcn/nsUnicodeToGB2312GL.cpp

Comment 6

[yueheng.xu]

Attachment: diff for intl/uconv/ucvcn/nsUnicodeToGB2312V2.cpp

Comment 7

[yueheng.xu]

Attachment: diff for intl/uconv/ucvcn/nsUnicodeToGBK.cpp

Comment 8

[yueheng.xu]

added [e-mail] at the Cc: list

Comment 9

[yueheng.xu]

Attachment: Updated diff for intl/uconv/ucvcn/gbku.h

Comment 10

[yueheng.xu]

Attachment: Updated diff for intl/uconv/ucvcn/nsUnicodeToGB2312GL.cpp

Comment 11

[yueheng.xu]

Attachment: Updated diff for intl/uconv/ucvcn/nsUnicodeToGB2312V2.cpp

Comment 12

[yueheng.xu]

Attachment: Updated diff for intl/uconv/ucvcn/nsUnicodeToGBK.cpp

Comment 13

[leger]

Due to slip in schedule, moving this bug from [6/01] to [Will be minus on 6/15] 
for fix deadline.

Comment 14

[yueheng.xu]

The fix has been checked in on last Friday.

Comment 15

[Teruko Kobayashi]

I verified this in 2000-06-05-08 Linux build.