396450 - Move logic out of nsDownloadManager.h

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Attachment: patch for checkin

Patch split off from bug 230870 (attachment 280259 [details] [diff] [review] which is r+ a1.9+), see bug 230870 comment 72 for naming.

This is xs.3 which moves AddToCurrentDownloads into .cpp and moves CompletedSuccessfully and IsInFinalStage into nsDownload as IsFinished and IsFinishable. Additionally IsInProgress is removed.

Patch is applied after the one for 396448.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 281205 [details] [diff] [review]
patch for checkin

For clarity, this is r=sdwilsh, a=mconnor

Comment 2

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.117; previous revision: 1.116
Checking in toolkit/components/downloads/src/nsDownloadManager.h;
new revision: 1.42; previous revision: 1.41

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using _Bonsai_:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsDownloadManager.h&branch=&root=/cvsroot&subdir=mozilla/toolkit/components/downloads/src&command=DIFF_FRAMESET&rev1=1.41&rev2=1.42

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsDownloadManager.cpp&branch=&root=/cvsroot&subdir=mozilla/toolkit/components/downloads/src&command=DIFF_FRAMESET&rev1=1.116&rev2=1.117