396453 - Convert DownloadManager flag variables into flag functions

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Attachment: patch for checkin

Patch split off from bug 230870 (attachment 280259 [details] [diff] [review] which is r+ a1.9+), see bug 230870 comment 72 for naming.

This is xs.5 and xs.6 for changing member variable flags into member function flags such as IsPaused, IsResumable, WasResumed, IsRealPaused which allows the removal of mPaused and mWasResumed which were duplicating data.

Patch is applied after the one for bug 396451.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 281208 [details] [diff] [review]
patch for checkin

For clarity, this is r=sdwilsh, a=mconnor

Comment 2

[Shawn Wilsher :sdwilsh]

Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.119; previous revision: 1.118
Checking in toolkit/components/downloads/src/nsDownloadManager.h;
new revision: 1.43; previous revision: 1.42