Closed
Bug 396497
Opened 18 years ago
Closed 18 years ago
Use should_set everywhere in process_bug
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file)
|
5.39 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Instead of checking "this field is defined, or dontchange is defined and we're not dontchange" everywhere over and over in process bug, I made a subroutine called should_set that checks that for us. We should use this everywhere in process_bug as a nice little cleanup.
|
Assignee | |
Comment 1•18 years ago
|
||
Here you go. I tested this, and it seems to be working fine.
This also now allows users to set the QA Contact to empty on a single bug, while still working correctly when useqacontact is off.
Attachment #281255 -
Flags: review?(LpSolit)
|
|
||
Comment 2•18 years ago
|
||
Comment on attachment 281255 [details] [diff] [review]
v1
r=LpSolit
Attachment #281255 -
Flags: review?(LpSolit) → review+
|
|
||
Updated•18 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 3•18 years ago
|
||
We should relnote the QA Contact thing.
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi
new revision: 1.387; previous revision: 1.386
done
|
|
||
Comment 4•18 years ago
|
||
(In reply to comment #3)
> We should relnote the QA Contact thing.
See bug 321834. Moving the relnote keyword there.
Keywords: relnote
You need to log in
before you can comment on or make changes to this bug.
Description
•