396529 - Key-nav is blocked in preference page

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Tim Miao]

Key-nav was blocked by Application card.
Steps to reproduce:
1. Choose menu Edit-Preferences to open firefox preferences window.
2. Press Right/Left arrow to switch tabs between different panels.

Bug observations:
Key-nav will be blocked at Applications page, you can not nav forward/backward any more.

Comment 1

[Ginn Chen]

seems focus is grabbed for first loading Applications page,

press tab several times to re-focus the top panel list, then Right/Left arrow will work again.

Comment 2

[Tim Miao]

Yes, this is a workaround. And in past, it will not block the key nav. Could we keep putting focus on the list item again?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The Applications pane focuses the filter text box explicitly, I believe. It probably shouldn't do that.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: removes explicit focus

(In reply to comment #3)
> The Applications pane focuses the filter text box explicitly, I believe.

It actually focuses the list of types.

> It probably shouldn't do that.

I agree.  Here's a patch that removes the explicit focus.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Incidentally, this behavior is a remnant from the old Download Actions dialog, which focused its list of types when you opened it.  But that behavior doesn't make sense now that the list is embedded in a prefpane.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 281395 [details] [diff] [review]
patch v1: removes explicit focus

Requesting approval for this super-trivial polish fix to make the initial focused element after loading the Applications prefpane consistent with all the other prefpanes.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.9; previous revision: 1.8
done