Closed
Bug 396616
Opened 18 years ago
Closed 18 years ago
SetParam error when changing a group name in editgroups.cgi
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: altlist, Assigned: altlist)
Details
Attachments
(1 file)
|
306 bytes,
patch
|
mkanat
:
review+
LpSolit
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier:
Bugzilla has an internal error when I attempt to change a group name in editgroups.cgi. That's because it is not able to find the SetParam() function.
Reproducible: Always
|
Assignee | |
Comment 1•18 years ago
|
||
This small patch fixes the problem.
|
||
Comment 2•18 years ago
|
||
In what version? SetParam is gone in HEAD and 3.0, I'm pretty sure.
|
|
Assignee | |
Comment 3•18 years ago
|
||
(In reply to comment #2)
> In what version? SetParam is gone in HEAD and 3.0, I'm pretty sure.
>
Main HEAD (cvs 1.21 for Bugzilla/Group.pm)? editparams and editvalues also references it.
|
|
||
Comment 4•18 years ago
|
||
I tested on 3.1.2, 3.0.2 and 2.22.3, but I'm unable to reproduce the bug.
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
|
|
Assignee | |
Comment 5•18 years ago
|
||
I should have clarified something.
The specific group name I was trying to rename was "TimeTracking", which was tied to the timetrackinggroup parameter. I had no problems renaming other user defined groups.
Could you reconfirm?
Thanks,
Albert
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
|
|
||
Comment 6•18 years ago
|
||
2.22.x and 3.0.x are not affected, but 3.1.x is.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 3.2
Version: unspecified → 3.1.1
|
|
||
Updated•18 years ago
|
Flags: testcase?
|
|
||
Comment 7•18 years ago
|
||
Comment on attachment 281385 [details] [diff] [review]
suggested patch
Yes, that looks right.
Attachment #281385 -
Flags: review+
|
|
||
Comment 8•18 years ago
|
||
Comment on attachment 281385 [details] [diff] [review]
suggested patch
OK, this indeed fixes the problem. Thanks for the fix. r=LpSolit
Attachment #281385 -
Flags: review+
|
|
||
Updated•18 years ago
|
Assignee: administration → altlist
|
|
||
Comment 9•18 years ago
|
||
Checking in Bugzilla/Group.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v <-- Group.pm
new revision: 1.22; previous revision: 1.21
done
Status: NEW → RESOLVED
Closed: 18 years ago → 18 years ago
Flags: approval+
Resolution: --- → FIXED
|
|
||
Updated•18 years ago
|
Flags: testcase?
You need to log in
before you can comment on or make changes to this bug.
Description
•