Closed Bug 396648 Opened 17 years ago Closed 17 years ago

nsPermissionManager tries to open two files that usually don't exist

Categories

(Core :: Networking: Cookies, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sayrer, Assigned: sayrer)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch check that they exist (obsolete) — Splinter Review
      No description provided.
Attachment #281414 - Flags: superreview?(cbiesinger)
Attachment #281414 - Flags: review?(cbiesinger)
What's the point of this change?
(In reply to comment #1)
> What's the point of this change?
> 

To avoid IO errors on startup.
Comment on attachment 281414 [details] [diff] [review]
check that they exist

+    rv = oldPermissionsFile->Exists(&fileExists);
+    if (NS_SUCCEEDED(rv)) {

don't you need an && fileExists in this if?
Attachment #281414 - Flags: superreview?(cbiesinger)
Attachment #281414 - Flags: superreview+
Attachment #281414 - Flags: review?(cbiesinger)
Attachment #281414 - Flags: review+
Attached patch fix bool checkSplinter Review
Assignee: nobody → sayrer
Attachment #281414 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #281497 - Flags: approval1.9?
Comment on attachment 281497 [details] [diff] [review]
fix bool check

a=bzbarsky
Attachment #281497 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: