Closed
Bug 396648
Opened 17 years ago
Closed 17 years ago
nsPermissionManager tries to open two files that usually don't exist
Categories
(Core :: Networking: Cookies, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sayrer, Assigned: sayrer)
Details
Attachments
(1 file, 1 obsolete file)
2.28 KB,
patch
|
bzbarsky
:
approval1.9+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #281414 -
Flags: superreview?(cbiesinger)
Attachment #281414 -
Flags: review?(cbiesinger)
Comment 1•17 years ago
|
||
What's the point of this change?
Assignee | ||
Comment 2•17 years ago
|
||
(In reply to comment #1) > What's the point of this change? > To avoid IO errors on startup.
Comment 3•17 years ago
|
||
Comment on attachment 281414 [details] [diff] [review] check that they exist + rv = oldPermissionsFile->Exists(&fileExists); + if (NS_SUCCEEDED(rv)) { don't you need an && fileExists in this if?
Attachment #281414 -
Flags: superreview?(cbiesinger)
Attachment #281414 -
Flags: superreview+
Attachment #281414 -
Flags: review?(cbiesinger)
Attachment #281414 -
Flags: review+
Assignee | ||
Comment 4•17 years ago
|
||
Assignee: nobody → sayrer
Attachment #281414 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #281497 -
Flags: approval1.9?
Comment 5•17 years ago
|
||
Comment on attachment 281497 [details] [diff] [review] fix bool check a=bzbarsky
Attachment #281497 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•