Closed
Bug 396657
Opened 18 years ago
Closed 18 years ago
remove unused mac widget interfaces and leftover unused code
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(2 files, 1 obsolete file)
|
15.83 KB,
patch
|
cbarrett
:
review+
roc
:
superreview+
roc
:
approval1.9+
|
Details | Diff | Splinter Review |
|
493 bytes,
patch
|
Details | Diff | Splinter Review |
nsIDragSessionMac and nsIPrintingContext are no longer used. Some of our old nsIPrintingContext impl remains, unused, and should be removed.
Attachment #281431 -
Flags: review?(cbarrett)
forgot one change
Attachment #281431 -
Attachment is obsolete: true
Attachment #281433 -
Flags: review?(cbarrett)
Attachment #281431 -
Flags: review?(cbarrett)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 281433 [details] [diff] [review]
fix v1.1
looks fine to me.
Attachment #281433 -
Flags: review?(cbarrett) → review+
Attachment #281433 -
Flags: superreview?(roc)
Attachment #281433 -
Flags: superreview?(roc)
Attachment #281433 -
Flags: superreview+
Attachment #281433 -
Flags: approval1.9+
landed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 5•18 years ago
|
||
What about xpfe/appshell/src/nsWebShellWindow.cpp which includes nsIMenuBar.h and is, at least, built on non-Mac XULRunner builds?
|
|
||
Updated•18 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 6•18 years ago
|
||
Attachment #281583 -
Flags: superreview?(roc)
Attachment #281583 -
Flags: review?(roc)
Attachment #281583 -
Flags: approval1.9?
Comment on attachment 281583 [details] [diff] [review]
Patch to fix XULRunner builds
I checked in a bustage fix to nsWebShellWindow.cpp.
Attachment #281583 -
Flags: superreview?(roc)
Attachment #281583 -
Flags: review?(roc)
Attachment #281583 -
Flags: approval1.9?
Thanks for the bustage fix roc. I swear I rebuilt my whole tree after applying that patch, I guess I still had headers in my objdir from before the patch.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•