396661 - OS/2 build break in nsTextFrameThebes

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Peter Weilbacher]

Attachment: obvious workaround

When compiling nsTextFrameThebes.cpp on OS/2 I get these errors:

X:/trunk/mozilla/layout/generic/nsTextFrameThebes.cpp: In member function `void
nsTextFrame::PaintTextDecorations(gfxContext*, const gfxRect&, const gfxPoint&,
const gfxPoint&, nsTextPaintStyle&, PropertyProvider&)':
X:/trunk/mozilla/layout/generic/nsTextFrameThebes.cpp:3810: error: parse error b
efore `.' token
X:/trunk/mozilla/layout/generic/nsTextFrameThebes.cpp:3814: error: request for m
ember `height' in `size', which is of non-class type `gfxSize ()(...)'
[...]

This is since the checkin from bug 394832. I don't see anything wrong with the code, but maybe GCC 3.3.5 that we are still forced to use has a bug (the problem looks similar to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11796 to me). Although I am bit surprised that we haven't encountered this problem before, the obvious workaround to use a standard C cast works...

Comment 1

[Walter Meinl]

Just to confirm, your patch is working here

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't want to change back to a C-style cast. You can actually just take the gfxFloat cast out; now that 'app' is a float, the division will be floating point anyway.

Comment 3

[Peter Weilbacher]

Attachment: remove cast

Doh! Could have noticed that myself...

Comment 4

[Peter Weilbacher]

Fix checked into trunk.