396725 - places organizer's content pane should allow different views to be easily plugged in

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect, P3)

Description

[Dietrich Ayala (:dietrich)]

a key benefit of the places organizer is the extensibility of the content pane. we should allow extension developers to easily hook into it.

- the navigation will need to store the view along with the location
- we should provide an interface that content views must implement

Comment 1

[Dietrich Ayala (:dietrich)]

from IRC:

johnm: dietrich: I'm talking about the places tree. http://mxr.mozilla.org/firefox/source/browser/components/places/content/tree.xml#295

johnm: its updated when the place is set, but it should be when load is called because the place setter calls load, but load is also called without place

johnm: like when applyFilters is called

dietrich: johnm: yep, load should should update the place attribute, sounds like a bug

johnm: that makes things much easier for me

johnm: I was kind of thinking it would make sense to move the info pane outside of the content deck, because I think it would be useful for other views implemented later, but I also understand keeping it with the tree

johnm: right now I move it out with js(because I use it with my other view), but I must have missed something because when I do that every other selection sets the title to Bookmark Toolbar(even though the url changes correctly)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Target Milestone was set to Firefox 3.1. Is it still valid?

Comment 3

[Dietrich Ayala (:dietrich)]

This doesn't block 3.1 as it's basically a non-P1 enhancement. I'd really like to see this fixed though, as it'd open up a whole new class of add-ons, so marking wanted+.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

not going to make 3.1 at this stage since would affect extensions

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

too risky for 3.5, asking to reevaluate for wanted 3.6

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Actually, we implemented this (or at least part of it) for Downloads view, there is now a ContentArea object that may be expanded in future based on the needs.