396782 - Trunk Builds do not render tab graphics

Status: VERIFIED FIXED

(Other Applications Graveyard :: QA Companion, defect, P1)

Description

[Al Billings [:abillings - ex-MoCo]]

Attachment: The example of the bug.

In current trunk builds, the tabs at the top of the QA extension are missing the graphics elements that draw the tabs. See attached image.

This was seen on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091704 Minefield/3.0a8pre.

Comment 1

[Jay Patel [:jay]]

Not a true blocker, but we should do something to make sure users can identify the tabs.  Most people will figure it out, but it'll be nice to fix this. 

Comment 2

[Al Billings [:abillings - ex-MoCo]]

This really needs to be fixed for Trunk now that we have betas.

Comment 3

[Jay Patel [:jay]]

I think Clint is looking into redoing the tabs...since they currently are dependent on the Firefox theme and will eventually break again even if we fix the current implementation.

Reassigning to Clint.

Comment 4

[cmtalbert]

I'm working on this, and I think that the proper thing to do here is to take
the look that the extension has in FFx 2 and make that work for all the builds.
 This will break the dependency that we have on the Firefox tab implementation,
but I think that's a good thing because we are inheriting all changes to the
browser's tab infrastructure, so if the user has a theme installed (say the new
mac proto theme) then our UI ends up looking really odd.

I'll attach screenshot examples.

Comment 5

[cmtalbert]

Attachment: FFx2 Tab look

This is the way things look in FFx2.  If we can just make this our default look, I think we're going to be fine.

Comment 6

[cmtalbert]

Attachment: Here's an example of what can happen if the user changes their theme (mac proto theme, ffx 3)

Note how this theme makes absolutely no sense for the way our GUI is structured (the tabs descend from the top, and not up from the bottom).

Comment 7

[Jay Patel [:jay]]

Making P1 since we need this before shipping for Firefox 3 compatibility.

Comment 8

[cmtalbert]

Attachment: Most minor set of changes to get tabs usable across versions

Zach,  here is a very minor set of changes that make the tabs look the same across different versions and different themes of the browser.  I spent a bit of time tweaking things, but decided that first, we needed basic functionality.  The only bit of tweaking done here was to make sure the "Q" tab didn't look smushed, but otherwise, the rest of the patch merely breaks the dependency on the browser's current tab theme.  Screenshot to follow.

Comment 9

[cmtalbert]

Attachment: Screenshot on minefield

Comment 10

[cmtalbert]

Fix checked in on trunk

Comment 11

[Al Billings [:abillings - ex-MoCo]]

Verified in 0.1.10 (the released version).