396920 - Invalid accesskeys for Show Columns and Sort in the Places Organizer's Views menu

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(no longer active)]

Attachment: Trivial fix

The accesskeys are "S" for both "Show Columns" and "Sort" in the Views menu of the Places Organizer.

A good fix will be changing the accesskey for "Show Columns" to "C", as implemented in the attached patch.

Comment 1

[(no longer active)]

Comment on attachment 281679 [details] [diff] [review]
Trivial fix

Requesting review from Seth, in hope of faster landing.

Comment 2

[(not reading, please use [e-mail] instead)]

fixed, thanks Ehsan.

Checking in chrome/browser/places/places.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.dtd,v  <--
places.dtd
new revision: 1.33; previous revision: 1.32
done

Comment 3

[Tracy Walker [:tracy]]

This doesn't need to be in Litmus. I'm sure it can be checked in a automated test harness.

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 5

[Tracy Walker [:tracy]]

removing ancient in-testsuite requests