Closed
Bug 396943
Opened 17 years ago
Closed 17 years ago
nsAbBaseCID.h requires a #define that's in an internal header file.
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
|
3.07 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
mailnews/addrbook/public/nsAbBaseCID.h uses NS_AB_DIRECTORY_FACTORY_CONTRACTID_PREFIX, this is defined in mailnews/addrbook/src/nsAbDirFactoryService.h Therefore extensions that correctly use just the public files won't be able to compile properly (or find the right details if they only have the public files), and its just wrong. So the attached patch moves the define from the internal file to the external and adjusts some #includes to go with it.
Attachment #281699 -
Flags: superreview?(bienvenu)
Attachment #281699 -
Flags: review?(bienvenu)
|
||
Updated•17 years ago
|
Attachment #281699 -
Flags: superreview?(bienvenu)
Attachment #281699 -
Flags: superreview+
Attachment #281699 -
Flags: review?(bienvenu)
Attachment #281699 -
Flags: review+
|
Assignee | |
Comment 1•17 years ago
|
||
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•