396991 - filter explanation should be removed from Applications prefpane

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When you filter the list of types in the Applications prefpane, we show a string explaining the obvious, which is that the list is filtered by your filter string.  faaborg has pointed out that we should remove this just as we removed the explanation of the prefpane from above the filter field.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: removes message

Here's the trivial patch that removes the message.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Requesting wanted-1.9 for this Applications prefpane polish fix.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 281757 [details] [diff] [review]
patch v1: removes message

>Index: browser/components/preferences/applications.xul

>-      <separator class="thin"/>
>-
>-      <label id="filterActiveLabel" hidden="true">
>-        &filterActive.label;
>-      </label>
>-
>-      <separator class="thin"/>

I'd keep one of the separators so the textbox doesn't end up too close to the richlistbox, but maybe that's just me. r=me either way.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: unrotted, and with one separator retained

This version of the patch is unrotted (trivial conflict due to changes in the same vicinity as the checkin for bug 396121) and leaves one of the separators per comment 3.  Requesting approval for this low risk polish fix for the Applications prefpane.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/applications.xul;
/cvsroot/mozilla/browser/components/preferences/applications.xul,v  <--  applications.xul
new revision: 1.4; previous revision: 1.3
done
Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.10; previous revision: 1.9
done
Checking in browser/locales/en-US/chrome/browser/preferences/applications.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/applications.dtd,v  <--  applications.dtd
new revision: 1.3; previous revision: 1.2
done