pageloader won't work with -tpchrome and self timing.

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: anodelman, Assigned: anodelman)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 281769 [details] [diff] [review]
removes bubbling onload handler from self timing tests

When working with self timing tests (those with '%' preceding the url in the manifest file) and the -tpchrome switch the pageloader fails with the message:

tp: Bubbling onload handler used with page that does its own timing?
Attachment #281769 - Flags: review?(vladimir)
Comment on attachment 281769 [details] [diff] [review]
removes bubbling onload handler from self timing tests

That would work, but I think you can just get rid of the addEventListener on line 153 -- that's where it's added in the first place.  That shouldn't be there, because it's automatically added and removed around each test; e.g. see the else clause of the place where you made the patch.
Comment on attachment 281769 [details] [diff] [review]
removes bubbling onload handler from self timing tests

Oh, while you're there, can you fix the typo in "capturig"? :)
(Assignee)

Comment 3

11 years ago
Created attachment 281839 [details] [diff] [review]
remove auto-add of bubbling onload handler

You are correct, removing it entirely fixes the problem.
Assignee: nobody → anodelman
Attachment #281769 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #281839 - Flags: review?(vladimir)
Attachment #281769 - Flags: review?(vladimir)
Comment on attachment 281839 [details] [diff] [review]
remove auto-add of bubbling onload handler

Great, thanks!
Attachment #281839 - Flags: review?(vladimir) → review+
(Assignee)

Comment 5

11 years ago
Checking in pageloader.js;
/cvsroot/mozilla/layout/tools/pageloader/pageloader.js,v  <--  pageloader.js
new revision: 1.5; previous revision: 1.4
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.