397048 - trunk needs msimg32 after cairo update

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Roy Tam]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8pre) Gecko/20070918 Firefox/2.0.0.8pre (Firefox musume)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.8pre) Gecko/20070918 Firefox/2.0.0.8pre (Firefox musume)

trunk needs msimg32 after cairo update, otherwise it fails to build.
mozcairo.lib(cairo-win32-printing-surface.obj) : error LNK2001: unresolved external symbol __imp__GradientFill@24
firefox.exe : fatal error LNK1120: 1 unresolved externals
make[5]: *** [firefox.exe] Error 96


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Roy Tam]

Attachment: mozilla\browser\app\makefile.in patch

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Do you know why the tinderbox do not have this problem ? They're building on Win 2k3 using VS 8 SP1.

Comment 3

[Phil Ringnalda (:philor)]

I would guess it's busted for static/non-libxul - tinderboxes are getting it from http://mxr.mozilla.org/seamonkey/source/toolkit/library/Makefile.in#230 and -enable-static doesn't get into /toolkit/library/, does it?

Comment 4

[Roy Tam]

(In reply to comment #3)
> I would guess it's busted for static/non-libxul - tinderboxes are getting it
> from http://mxr.mozilla.org/seamonkey/source/toolkit/library/Makefile.in#230
> and -enable-static doesn't get into /toolkit/library/, does it?
> 

I think so.

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 281823 [details] [diff] [review]
mozilla\browser\app\makefile.in patch

Drivers: essentially no risk, since it's in an #ifdef that official builds don't hit.

Comment 6

[Phil Ringnalda (:philor)]

browser/app/Makefile.in: 1.137

Comment 7

[Steve Snyder]

Please see bug 397388.  It seems to be the same problem, for Seamonkey.