397091 - OS/2 build break in widget code: nsWindow.cpp fallout of bug396657

Status: RESOLVED FIXED

(Core Graveyard :: Widget: OS/2, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a8pre) Gecko/2007092120 Minefield/3.0a8pre
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a8pre) Gecko/2007092120 

compiler stops during compilation of widget/src/os2/nsWindow.cpp
Error: nsIMenuBar.h not found
It is unconditional in the includes list. As it seems to be not needed deletion from nsWindow.cpp would be the solution

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Walter Meinl]

Attachment: remove the unneeded include

Comment 2

[Mike Kaply [:mkaply]]

Comment on attachment 281854 [details] [diff] [review]
remove the unneeded include

Actually we do need an nsIMenuBar reference for the header, but we can just use class nsIMenuBar

Comment 3

[Mike Kaply [:mkaply]]

Checked in a fix for this.

Comment 4

[Josh Aas]

What exactly was the fix for this? Can you explain it here or post a patch?

Comment 5

[Peter Weilbacher]

Josh, perhaps you have gotten an answer through another medium. If not, you can see the checking from

http://bonsai.mozilla.org/cvsquery.cgi?who=kaply&whotype=regexp&date=explicit&mindate=2007-09-21+12%3A41&maxdate=2007-09-21+12%3A41

Mike removed the nsIMenubar #include from nsWindow.cpp and instead added the forwarding class definition for nsIMenuBar in nsWindow.h.