397111 - Places Organizer , next menu won't expand when the pointer gets there

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007092112 Minefield/3.0a8pre ID:2007092112

repro:
Open FF
menu [Bookmarks] -> [Organize Bookmarks]
In the Places Organizer window click on menuitem [Organize] (the menu expands)
move the pointer to the right, over [Views] or [Import and Backup]

result:
The [Organize] does not collapse and [Views] or [Import and Backup] don't expand

expected:
behave like main menubar in FF

Comment 1

[Hideo Oshima]

Linux trunk build also has the same problem.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch by Martijn Wargers

This patch has been posted by on Bug 406574

He said:
> Press "Organize" in Places Organizer. A menu will show up. Drag the mouse to
> the right. I would expect "Views" to pop up now, but this does not happen.
> 
> This makes it work for me. I basically copied this from bug 203556.
>

Comment 6

[Asaf Romano (gone)]

Comment on attachment 291427 [details] [diff] [review]
patch by Martijn Wargers

>Index: browser/components/places/content/places.js
>===================================================================

>+var PlacesToolbar = {
>+  // make places toolbar act like menus
>+  openedMenuButton: null,
>+  autoOpenMenu: function (aTarget)
>+  {
>+    if (this.openedMenuButton &&
>+        this.openedMenuButton != aTarget &&
>+        aTarget.localName == "toolbarbutton" &&
>+        (aTarget.type == "menu" ||
>+         aTarget.type == "menu-button")) {

in fewer lines please, could also just check the "menu-button" case.

r=mano otherwise.

Comment 8

[Hideo Oshima]

(In reply to comment #4)
> Created an attachment (id=291427) [details]
> patch by Martijn Wargers

I tested the patch.
It seems good for me.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007122311 Minefield/3.0b3pre

Comment 9

[Marco Bonardo [:mak]]

Attachment: patch by Martijn Wargers, updated

Martjin i hope you don't mind if i addressed review comments in your patch (only changed some newline)

Mano: menu check cannot be taken away, making only menu-button check does not work

bringing over Mano's review

Comment 10

[Marco Bonardo [:mak]]

notice that the toolbar acts like a menu with mouse but not with keyboard right/left cursor (should i fill a bug on that?)

Comment 11

[Dão Gottwald [:dao]]

(In reply to comment #10)
> notice that the toolbar acts like a menu with mouse but not with keyboard

Maybe we should use an actual menubar from the start?

Comment 12

[Michael Monreal [:micmon]]

(In reply to comment #11)
> (In reply to comment #10)
> > notice that the toolbar acts like a menu with mouse but not with keyboard
> 
> Maybe we should use an actual menubar from the start?
> 

I would vote for this, too. I guess the Mac version will try to style it as a menu too, and there is a bug to remove the icons for Linux builds. 

Comment 13

[Martijn Wargers (dead)]

Checking in places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul

new revision: 1.100; previous revision: 1.99
done
Checking in places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.120; previous revision: 1.119
done

Marco, thanks for updating the patch. I checked this in now.

There is probably a bug filed for using a normal menubar instead.

Comment 14

[Ria Klaassen (not reading all bugmail)]

Marvellous; verified fixed.

Comment 15

[u294409]

[[ there is a bug to remove the icons for Linux builds ]]
What icons?

Comment 16

[Michael Monreal [:micmon]]

The icons in front of the "menus"/buttons (Organize, View,  Import). The current icons normally have other meanings, so they don't really help at all.

Comment 17

[u294409]

So, Firefox must send request for icons (to freedesktop).

Comment 18

[Dão Gottwald [:dao]]

No, Firefox should be using a good old menu bar without icons. That's the underlying issue and "There is probably a bug filed" isn't really satisfying, which is why I wouldn't have resolved this bug. Re-implementing all menu bar features to emulate the correct behavior can't be the way to go.

Comment 19

[Martijn Wargers (dead)]

"There is probably a bug filed" isn't really a satisfying answer, but this bug was only about the "Places Organizer , next menu won't expand when the pointer gets there" issue.
Feel free to reopen this bug, if you think this bug should be about the "Firefox should be using a good old menu bar without icons" issue.

Comment 20

[Martijn Wargers (dead)]

(In reply to comment #19)
> Feel free to reopen this bug, if you think this bug should be about the
> "Firefox should be using a good old menu bar without icons" issue.

Ok, iiuc, this will happen in bug 400703.

Comment 21

[u294409]

@Dao: menubars should die :P . They're old and not idiot-friendly :P .

Comment 22

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv