Closed Bug 397147 Opened 13 years ago Closed 13 years ago

Move/Remove remaining sidebar code in xpfe/components/sidebar

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Attached patch cvs movesSplinter Review
In xpfe/components/sidebar we have:

src/nsSidebar.js - still used as the rdf datasource
resource/make-panel.pl - not referenced anywhere
resource/locales/en-US/customize-panel.dtd - not referenced anywhere, and the strings contained also not referenced.

Lets move nsSidebar.js to suite/common/sidebar and drop the rest of it.
Attachment #281920 - Flags: superreview?(neil)
Attachment #281920 - Flags: review?(kairo)
Attached patch Build changesSplinter Review
Attachment #281921 - Flags: superreview?(neil)
Attachment #281921 - Flags: review?(kairo)
Attachment #281920 - Flags: review?(kairo) → review+
Attachment #281920 - Flags: superreview?(neil) → superreview+
Depends on: 397339
Comment on attachment 281921 [details] [diff] [review]
Build changes

OK, looks good... though I wonder what exactly was generated with make-panels.pl and with what we have replaced whatever that is or if at all, and how we'll go into the future with those sidebars at all...
Attachment #281921 - Flags: review?(kairo) → review+
Attachment #281921 - Flags: superreview?(neil) → superreview+
Comment on attachment 281921 [details] [diff] [review]
Build changes

Requesting approval for 1.9 as this touches Firefox build files.

It is moving SeaMonkey specific sidebar code to /suite and therefore should have no effect on Firefox.
Attachment #281921 - Flags: approval1.9?
Moving to core/build config so the approval request might actually get looked at.

<rant>how sad it is when approvers can't have a quick look in another product for relevant requests</rant>
Status: NEW → ASSIGNED
Component: Sidebar → Build Config
Product: Mozilla Application Suite → Core
QA Contact: build-config
Attachment #281921 - Flags: approval1.9? → approval1.9+
Patch checked in -> fixed.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.