397188 - FCK Editor no longer working on Firefox trunk

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Biju]

http://www.fckeditor.net/demo not working

Gets following error message

Error: FCKeditorAPI has no properties
Source File: http://www.fckeditor.net/fckeditor/editor/js/fckeditorcode_gecko.js
Line: 37

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Regression range:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&branchtype=match&date=explicit&mindate=2007-06-04+03%3A00&maxdate=2007-06-05+06%3A00

Most likely a regression from bug 382509 (see also bug 390859 and bug 394073).

The editor code from that page is an iframe that points to http://www.fckeditor.net/fckeditor/editor/fckeditor.html, which dynamically loads http://www.fckeditor.net/fckeditor/editor/js/fckeditorcode_gecko.js , which does call eval to define "FCKeditorAPI".

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

The patch in bug 383682 fixes this for me.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

This now works for me. Marking fixed as a result of bug 383682.

Comment 4

[Bob Clary [:bc] (inactive)]

covered by the tests referenced in bug 383682

Comment 5

[Samuel Sidler (old account; do not CC)]

Fixed on the branch in bug 382509.

Comment 6

[Al Billings [:abillings - ex-MoCo]]

How was this broken in branch in the first place? Pre-patch, the FCKeditor is working fine (as it is after the patch). I compared 2.0.0.12 and 2.0.0.13rc1.

Comment 7

[Samuel Sidler (old account; do not CC)]

Al: It's not. There were several bugs that were regressions from bug 382509. We need to make sure those regressions don't exist.

Comment 8

[Al Billings [:abillings - ex-MoCo]]

After speaking to SS, this is clearer. No regressions caused with the editor. Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/2008031114 Firefox/2.0.0.13.