397204 - BeOS Firefox resource file contains inappropriate MIME-types

Status: RESOLVED WONTFIX

(Firefox :: File Handling, defect)

Description

[Doug Shelton]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.8pre) Gecko/20070919 BonEcho/2.0.0.8pre
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8.1.8pre) Gecko/20070919 BonEcho/2.0.0.8pre

current resource file includes MIME-types for mail.  These should not be included in Firefox resource file.   They are appropriate for Thunderbird.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Doug Shelton]

Attachment: Revised BeOS Resource File with correct MIME-types

Comment 2

[Doug Shelton]

The proposed resource file should be committed to both the trunk and 2.0 branch.

Comment 3

[Sergei Dolgov]

Comment on attachment 281968 [details]
Revised BeOS Resource File with correct MIME-types

Doug, which way you made that file? - I see empty BeOS:FILE_TYPES in MSGG (Arhiced BMessage) section. Problem is that that section is most tricky part in resource for editing, as this is compiled and archived/serialized code. Thus, with GUI resource editors available in BeOS it can replace the strings there or section at whole in best case, all other operations are doubtful. I will try to create something useful ASAP, with some workarounds, though.

Comment 4

[Sergei Dolgov]

Attachment: resource file candidate

I replaced mail and news part of BMessage with image/gif and image/png which looks safe and quite natural :) Please test carefully if you really see those (and all previouis) MIME types in that section

Comment 5

[Doug Shelton]

Sergei, I created the file using FileType Tracker add-on editor, then examined it with QuickRes to double check.  I wonder what went wrong?

Comment 6

[Sergei Dolgov]

Doug, did you do it under Zeta or BeOS?
I'm confused myself about situation, why Resourcer (most advanced resource editor) do not see those strings in your modernized file, while recognizes it in original FF resource file. And why I really see those strings somehow with QuickRes.

Maybe you will describe procedure of that file creation with FileType add-on more detailed in our blog at livejournal or in private mail?

Comment 7

[Doug Shelton]

Comment on attachment 282000 [details]
resource file candidate

I've tested with this version.  I suggest we use it instead of the one currently in the branch.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 282000 [details]
resource file candidate

Moving request to next release

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 282000 [details]
resource file candidate

taking comment 7 as a r+ from doug

approved for 1.8.1.10, a=dveditz for release-drivers

Comment 10

[Doug Shelton]

Thank you, Daniel!  Sergei, would you have a chance to commit this change?

Comment 11

[Sergei Dolgov]

(In reply to comment #10)
> Thank you, Daniel!  Sergei, would you have a chance to commit this change?
> 
'll try this weekend

Comment 12

[Sergei Dolgov]

Checking in mozilla/browser/app/apprunner-beos.rsrc;
/cvsroot/mozilla/browser/app/apprunner-beos.rsrc,v  <--  apprunner-beos.rsrc
new revision: 1.1.4.2; previous revision: 1.1.4.1
done

Comment 13

[Doug Shelton]

Thank you, Sergei!

Comment 14

[Sergei Dolgov]

(In reply to comment #13)
> Thank you, Sergei!
> 
Don't forget about verification to close bug at some moment, currently we marked problem fixing with keyword only

Comment 15

[Doug Shelton]

Marked as fixed.  Should we commit this to the trunk as well?  If yes, I'll reopen.

Comment 16

[Sergei Dolgov]

(In reply to comment #15)
> Marked as fixed.  Should we commit this to the trunk as well?  If yes, I'll
> reopen.
> 
1)According to rules here
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8
"# Add the fixed1.8.1.10 keyword to the bug when it has been checked into the branch
# QA replaces that with verified1.8.1.10 when the fix has been tested in a branch build"
2)If we have hope to restore once our trunk (Haiku, Haiku, where you are?:) - why not?

Comment 17

[Doug Shelton]

I just completed a build with this fix in place and am using it as I write this.  Hopefully QA will see this and mark as Verified.  I'm reopening the bug since according to process, I closed it too soon.  Sergei, if you get a chance, please commit to trunk also.

Comment 18

[Sylvestre Ledru [:Sylvestre]]

I think this is will be ever fixed, closing.