Closed Bug 397248 Opened 17 years ago Closed 17 years ago

potential FMR in nsNativeTypes.cpp

Categories

(Core :: js-ctypes, defect)

Product:
Core
Component:
js-ctypes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: Biesinger, Unassigned)

References

(
URL
)

Details

libSpec.value.pathname_u = PromiseFlatString(name).get();

That doesn't do the right thing if name is not a flat string already, because then the object will be freed after this line.


while I'm here:
            rv = pCall->QueryInterface(NS_GET_IID(nsINativeMethod), (void**)_retval);

seems like this could just be:
  NS_ADDREF(*_retval = pCall);
fixed on trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Other Applications → Core
You need to log in before you can comment on or make changes to this bug.