After dragging in and out of textarea, no caret or readonly caret is shown

VERIFIED FIXED

Status

()

Core
Editor
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: mrbkap)

Tracking

({regression, testcase})

Trunk
x86
Windows XP
regression, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
To reproduce the bug:
- Drag some text to the textarea, but don't drop
- Then drag it outside the textarea again (and drop it somewhere)
- Focus the textarea

Expected result:
- Blinking caret in the textarea

Actual result:
- No caret or readonly caret in the textarea

I can look for a regression range, if wanted (my guess would be a regression of  bug 287813)
(Assignee)

Comment 1

10 years ago
Created attachment 282267 [details] [diff] [review]
Proposed fix

This patch relies on DragExits always being fired before the next DragEnter, but I think that's a reasonable assumption (unlike all the other assumptions I've made in this code). We simply weren't restoring the caret in all the right places.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #282267 - Flags: superreview?(roc)
Attachment #282267 - Flags: review?(roc)
Attachment #282267 - Flags: superreview?(roc)
Attachment #282267 - Flags: superreview+
Attachment #282267 - Flags: review?(roc)
Attachment #282267 - Flags: review+
Attachment #282267 - Flags: approval1.9+
(Assignee)

Comment 2

10 years ago
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

10 years ago
Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100104 Minefield/3.0a9pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.