397330 - Don't call SuspendRedraw during InsertFrames

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Attachment: Use base class InsertFrames

See bug 374037, particularly bug 374037 comment 50

Comment 1

[Jonathan Watt [:jwatt]]

Comment on attachment 282089 [details] [diff] [review]
Use base class InsertFrames

Start at bug 374037 comment 46.

On looking at the code more closely, the only concern I had was that this change would cause the code here:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/svg/base/src/nsSVGPathGeometryFrame.cpp&rev=1.100&mark=753-768#737

to be called too early. That's not the case. Or rather it won't be called any earlier than it already is, since, if the only SuspendRedraw call was the call in nsSVGOuterSVGFrame::InsertFrames, then the UnsuspendRedraw call there will cause it to be called at essentially the same point during frame construction.

Comment 2

[Robert Longson [:longsonr]]

checked in.