Starting Venkman with -venkman on the commandline hides statusbar

RESOLVED FIXED

Status

Other Applications
Venkman JS Debugger
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Karsten Düsterloh, Assigned: Robert Ginda)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 282174 [details] [diff] [review]
show statusbar by default, hide component-bar for non-Mojiri

When starting Venkman from the (SM or TB) commandline with -venkman, the statusbar is missing. It's there if you open Venkman from SM's Tools menu.
Attachment #282174 - Flags: review?(gijskruitbosch+bugs)

Comment 1

10 years ago
Comment on attachment 282174 [details] [diff] [review]
show statusbar by default, hide component-bar for non-Mojiri

>     if (console.host == "Firefox") {
>         tasksMenu.parentNode.removeChild(tasksMenu);
>         winMenu.parentNode.removeChild(winMenu);
>-    } else {
>-        comBar.collapsed = false;
>+        comBar.collapsed = true;
>     }

This hides the component bar on suite and friends. Why?
(Reporter)

Comment 2

10 years ago
> >     if (console.host == "Firefox") {
> >         tasksMenu.parentNode.removeChild(tasksMenu);
> >         winMenu.parentNode.removeChild(winMenu);
> >-    } else {
> >-        comBar.collapsed = false;
> >+        comBar.collapsed = true;
> >     }
> 
> This hides the component bar on suite and friends.

No. The componentbar is visible by default if the statusbar is shown, and this code hides it for Firefox and co...




(JFTR, if anyone else is wondering: the view-manager.js portion of this diff does not belong to this patch and is already checked in anyway.)

Comment 3

10 years ago
(In reply to comment #2)
> > >     if (console.host == "Firefox") {
> > >         tasksMenu.parentNode.removeChild(tasksMenu);
> > >         winMenu.parentNode.removeChild(winMenu);
> > >-    } else {
> > >-        comBar.collapsed = false;
> > >+        comBar.collapsed = true;
> > >     }
> > 
> > This hides the component bar on suite and friends.
> 
> No. The componentbar is visible by default if the statusbar is shown, and this
> code hides it for Firefox and co...

OK, so I need to be more awake when trying to read this. Sorry.

Either way, that makes me wonder - if starting venkman from Tools > JS Debugger doesn't show it on Firefox already, and did on Suite, why do you need this change?
(Reporter)

Comment 4

10 years ago
When I patch only openDebuggerWindow and start eg. TB with -venkman, I'll get a statusbar with an empty componentbar, which isn't nice.

Comment 5

10 years ago
Comment on attachment 282174 [details] [diff] [review]
show statusbar by default, hide component-bar for non-Mojiri

Those console.host things are not sane. Will file a followup bug. You get r+ for this though :-)
Attachment #282174 - Flags: review?(gijskruitbosch+bugs) → review+
(Reporter)

Comment 6

10 years ago
Landed the first two hunks on trunk (see end of comment #2).
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.