397431 - polish new protocol handling dialog to look like mockup

Status: NEW

(Firefox :: File Handling, defect, P4)

Description

[Dan Mosedale (:dmosedale, :dmose)]

The new protocol handling dialog should be polished in various ways to look like mockup in the URL field of this bug.

Requesting blocking-1.9.

Comment 1

[Florian Quèze [:florian]]

I think everything that is in the mockup and not already in current trunk is covered by other bugs or was dropped for Firefox 3.

I suggest we resolve this as WORKSFORME.

Cc'ing Alex so that he can tell if I missed something important from the mockup.

Comment 2

[Shawn Wilsher :sdwilsh]

Yeah, this was filed after we knew things were being dropped.  This is just to get the UI more like the mockups.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: protocol handling dialog in 2008010404

-Obvious height issue on OS X

-Let's drop the "Send to:" line, and change the default unknown protocol text to "Select an application to open this link:"

-Can we set a fixed height for the rows in the richlist view?

-We need to get gradients for the selected item in all richlist views, but that change is probably outside of the scope of this particular bug

-Are we going to do content specific text and icons for mailto, webcal, and other very common types (note the mailto example in the mockup)?

-Is there a separate bug for getting the app icons on each platform?

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> -Obvious height issue on OS X
Try a new profile?  This was fixed a while ago, but if your profile was created before then, it'll recall the old height.

> -Can we set a fixed height for the rows in the richlist view?
I think we did that already...

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

>Try a new profile?  This was fixed a while ago

Yep, sorry about that.

>> -Can we set a fixed height for the rows in the richlist view?
>I think we did that already...

Yeah, for some reason choose an application felt shorter, probably due to the button.  Either way, the height feels a little too small.  In general it's looking fine (but we do need to get the app icons in there).  I'll follow up with checking all of the padding and margins to make sure they are right, but I can file separate bugs for those tweaks when I have some free cycles.

Comment 6

[Florian Quèze [:florian]]

For the icons, we have bug 402620 about getting web app icons, and bug 404434 about the icons of the system default applications.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

we are going to want all of the app icons, not just the system default.  Can we leverage the app picker that Jim Mathies links to in this comment: 

https://bugzilla.mozilla.org/show_bug.cgi?id=404434#c3

Comment 8

[Florian Quèze [:florian]]

Err... I was listing the bugs we have about icons.  I should have been more clear, sorry.

Local applications (except the system default) already have icons.  And the code used to get them is the same as the one linked in this comment.

Comment 9

[Florian Quèze [:florian]]

Seems like this is more wanted than blocking. The only point in comment 3 that would be nice to fix here for Firefox 3 (and not already covered by another bug) is:

> -Let's drop the "Send to:" line, and change the default unknown protocol text
> to "Select an application to open this link:"

Reassigning to nobody as I won't have time to work more on this.