397443 - URL-encoded email addresses not properly unencoded

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Sort of eerie to accidently come across a bug I filed nearly three years ago, didn't understand how to do the Thunderbird followup myself or even what it affected, and decided it was SEP, but, this is the Thunderbird version of bug 277625 (particularly, #c5).

STR:
1. Send yourself HTML email, with a link to mailto:philringnalda%40gmail.com
2. Note that right-click, Copy Email Address gets you a correct "[e-mail]" from nsContextMenu.js
3. Note that right-click, Compose Email To and Add To Address Book... both get "philringnalda%40gmail.com"

This shouldn't have ever worked - the "this.target.ownerDocument" comes from where it's copied around in the various nsContextMenu.jses, where "this" is the nsContextMenu object, which sets its target property to the clicked-on node. While I was in the neighborhood, I cleared out the historical trail of safe access to content - Components.lookupMethod is deprecated to the point of giving an NS_WARNING to use Components.utils.lookupMethod (though the advice in xpccomponents.idl, to be sure whether you even want it in light of XPCNativeWrappers, is even better). xpfe, suite, and browser all trust the implicit wrapper, so I assume it's safe.

Comment 1

[Scott MacGregor]

Comment on attachment 282207 [details] [diff] [review]
Fix v.1

nice!

Comment 2

[Phil Ringnalda (:philor)]

mail/base/content/nsContextMenu.js 1.18
mail/base/content/mailContextMenus.js 1.28