397466 - Remove autocomplete-security-wrapper

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect)

Description

[Dão Gottwald [:dao]]

As of Firefox 2, the location bar isn't styled natively, which means that the autocomplete-security-wrapper hack from bug 263750 isn't needed anymore.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Gavin: This patch is tested on Linux and (as one might expect) doesn't seem to have any side effects.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I started looking into this, so I'd like to finish this review if you don't mind. I'll try to finish this today.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 282233 [details] [diff] [review]
patch

Okay, I thought you would be too busy.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

In reply to comment #0)
> As of Firefox 2, the location bar isn't styled natively

I'm not sure I understand. The problem in bug 248419 was solved by making sure that autocomplete-textbox-container wasn't natively styled (attachment 161139 [details] [diff] [review]). It was then replaced by this hack in bug 263750, because non-native styling for that element caused trouble with the border. What's changed since then that makes unnecessary? The new Firefox 2 theme disabled native themeing on the URL bar element itself (http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/themes/winstripe/browser/browser.css&rev=1.107&mark=863#855), but it didn't touch autocomplete-textbox-container as far as I can tell.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> I'm not sure I understand. The problem in bug 248419 was solved by making sure
> that autocomplete-textbox-container wasn't natively styled (attachment 161139 [details] [diff] [review]).

That patch looks void to me. autocomplete-textbox-container is a hbox that doesn't have an appearance by default.

> It was then replaced by this hack in bug 263750, because non-native styling for
> that element caused trouble with the border. What's changed since then that
> makes unnecessary? The new Firefox 2 theme disabled native themeing on the URL
> bar element itself

Yeah, that's the point, as far as I understand the issue. The problem with the border came with the appearance of the textbox, which was changed with the new theme.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> That patch looks void to me. autocomplete-textbox-container is a hbox that
> doesn't have an appearance by default.

Well, bug 248419 comment 10, bug 248419 comment 14, and the existence of bug 263750 seem to indicate that it isn't void, so I'm not sure what's going on here. I've been having a few problems with my Linux VMs so testing this has taken longer than it normally would.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 282233 [details] [diff] [review]
patch

looks like the location bar might get back the native appearance.

Comment 9

[Dão Gottwald [:dao]]

Well I still don't see a difference with native styling.
.autocomplete-textbox-container and #autocomplete-security-wrapper (the single child of the former) are vboxes with no appearance, the same dimensions, background color etc..

Comment 10

[Dão Gottwald [:dao]]

(In reply to comment #9)
> .autocomplete-textbox-container and #autocomplete-security-wrapper (the single
> child of the former) are vboxes

hboxes

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch

tested on Linux:

https://build.mozilla.org/tryserver-builds/2007-12-26_12:[e-mail]-1198701770/

Comment 12

[Dão Gottwald [:dao]]

Bug 405210 is going to give an appearance to .autocomplete-textbox-container on Linux, hence the hack will be needed again.