397523 - Trunk tinderboxes should have Breakpad crash reporter disabled

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

A patch was landed today that allowed the build to finish but the app crashed on startup ((bug 396758), which spawns the Breakpad reporter. On windows this is pretty critical because it prevents crashreporter.exe from being written on subsequent builds, and so they burn. On Linux and Mac you get big collections dialogs. The actual reports aren't useful because we don't upload hourly symbols to the crash server (there was some talk about changing this), so we should be setting MOZ_CRASHREPORTER_NO_REPORT=1 in the environment of the tinderboxes.

There are two parts to this bug

1) we should add this to the sysprep scripts
2) we need to retro-fit this to existing tinderboxes

For the latter, I've done fx-win32-tbox and tbnewref-win32-tbox already.

Comment 1

[J. Paul Reed [:preed]]

So, just to confirm, this is all platforms, not just win32?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #1)
> So, just to confirm, this is all platforms, not just win32?

Looks like all platforms, based on spot checks of the linux and mac boxes for Firefox.

sea-win32-tbox & sb-win32-tbox were already done, and I'll do xr-win32-tbox now, so that's all the windows boxes taken care of.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

The sensible way to do this is in tinder-config.pl with  
  $ENV{MOZ_CRASHREPORTER_NO_REPORT} = '1';

I'll add that to all the trunk configs and remove declarations in .bash_profile et al.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #3)
> The sensible way to do this is in tinder-config.pl with  
>   $ENV{MOZ_CRASHREPORTER_NO_REPORT} = '1';
> 
> I'll add that to all the trunk configs and remove declarations in .bash_profile
> et al.

This is done for all 3 platforms for Firefox, Lightning, Thunderbird, and XULRUnner. It was already set for Sunbird & SeaMonkey. 

I'll close this bug once I've confirmed the change is being picked up properly.

Comment 5

[Martin Schröder [:mschroeder]]

(In reply to comment #4)
> This is done for all 3 platforms for Firefox, Lightning, Thunderbird, and
> XULRUnner. It was already set for Sunbird & SeaMonkey. 
> 

I don't think Lightning needed that change because it's "only" an extension.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #5)
> I don't think Lightning needed that change because it's "only" an extension.

That was my first thought too, but there is a MozillaAliveTest on the underlying Thunderbird build, so I played it safe. 

Forgot to mention that I checked with ause before making these changes.