397545 - jsDriver.pl claims e4x/Regress/regress-380833.js fails

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Attachment: test output

When I run the tests with jsDriver.pl, this one fails:

  http://lxr.mozilla.org/mozilla/source/js/tests/e4x/Regress/regress-380833.js

But when I cat together the relevant shell.js files and run it manually, the last line of output is:

  PASSED! Section 1 of test - Crash during GC after uneval

I think the test is actually passing and jsDriver.pl is incorrectly logging it as a failure, maybe because the output (see attachment) contains the string FAILED.

Comment 1

[Bob Clary [:bc] (inactive)]

Yep, it happens when you don't specify -R as an option due to 

            # watch for failures
            if ($line =~ /failed!/i) {
                $failure_lines .= $line;
            }

in execute_tests. Personally, I would just like to make the default -R and forget the old behavior of just looking for FAILED!

I'm open to suggestions.

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: patch v1

See if this works for you.

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 282391 [details]
patch v1

Works for me.

Comment 4

[Bob Clary [:bc] (inactive)]

/cvsroot/mozilla/js/tests/jsDriver.pl,v  <--  jsDriver.pl
new revision: 1.71; previous revision: 1.70