Closed Bug 397570 Opened 17 years ago Closed 17 years ago

"Use first binding" trick doesn't work if ID is omitted

Categories

(Core :: XBL, defect)

x86
macOS
defect
Not set
minor

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jruderman, Unassigned)

Details

(Keywords: testcase)

Attachments

(2 files)

The trick in bug 366770 doesn't work if you leave out the ID on the <binding> tag.  That seems strange, since the ID isn't referenced.  It had me confused for a few minutes while I tried to figure out why my XBL wasn't working.

In addition to making the XBL not work, it triggers an assertion, but that's a separate bug (bug 397568).
According to the documentation, this is required:
http://developer.mozilla.org/en/docs/XBL:XBL_1.0_Reference:Elements#binding
But I guess it could be changed, though.
We store nsXBLPrototypeBindings in an nsObjectHashtable using the binding ID as a the key, so we don't currently support <binding>s without IDs.
I'm fine with marking this INVALID. Yes, it's a bit weird, but I don't really see a need to spend code on changing it.
I'm going to wontfix this, sorry.  we also use the ID to disambiguate the binding proto class names, etc.  I don't think it's worth rewriting a good chunk of XBL to support markup that is explicitly non-conforming.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Ok.  It would be nice if this resulted in a clearer error message, but none of XBL's error messages are particularly clear at the moment.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: