397583 - Settings Tab: Disable all Notifications should disable UI

Status: RESOLVED FIXED

(Other Applications Graveyard :: QA Companion, defect, P1)

Description

[cmtalbert]

Click on Settings Tab
Click on "Disable All Notifications"

== Expected Results ==
All the checkboxes below that should be disabled

== Actual Results ==
They aren't

Comment 2

[Jay Patel [:jay]]

This sounds like an easy one. 

Comment 3

[Jay Patel [:jay]]

I'll take a look at this to see if I can figure out how to auto-uncheck the other boxes.  Will leave it assigned to Zach for now.

Comment 4

[Jay Patel [:jay]]

I gave this a shot and was not able to get the behavior I wanted.  Lowering severity and priority, since this can easily be implemented for a future version.  Don't need it for QAX v1.

Comment 5

[cmtalbert]

This is part of notification support, marking P1

Comment 6

[cmtalbert]

This is the largely commented out (and probably not fully implemented) notification support.  Heather, can you look into this and see what needs to move forward with us through the redesign and see if you can get this feature working again?  Assigning to Heather.

Comment 7

[Heather Arthur [:harth]]

Attachment: Patch for disabling checkboxes and syncing prefs

This patch adds a preference "enableNotification" and adds a checkbox beside "Notify me when:". Unchecking this will disable all of the notification preference checkboxes (not uncheck them), checking it will enable them. Open to suggestions about the UI for this.

I also had to change when we save the preferences back from the UI. Before we were only saving them when we switched tabs (I don't even think we saved them when we closed the window), this doesn't really make sense for notification preferences, as the user could open up QAC just to change notifications and minimize/close it expecting them to be changed.

Comment 8

[cmtalbert]

(In reply to comment #7)
> Created an attachment (id=356125) [details]
> Patch for disabling checkboxes and syncing prefs
> 
> This patch adds a preference "enableNotification" and adds a checkbox beside
> "Notify me when:". Unchecking this will disable all of the notification
> preference checkboxes (not uncheck them), checking it will enable them. Open to
> suggestions about the UI for this.
> 
> I also had to change when we save the preferences back from the UI. Before we
> were only saving them when we switched tabs (I don't even think we saved them
> when we closed the window), this doesn't really make sense for notification
> preferences, as the user could open up QAC just to change notifications and
> minimize/close it expecting them to be changed.

This looks really good.  I like the UI for it.  Do you want a review on this?

Comment 9

[cmtalbert]

Comment on attachment 356125 [details] [diff] [review]
Patch for disabling checkboxes and syncing prefs

looks good.

Comment 10

[cmtalbert]

Sending        chrome/content/settings.js
Sending        chrome/content/tabs/settings.xul
Sending        chrome/skin/qa.css
Sending        defaults/preferences/qa.js
Transmitting file data ....
Committed revision 21595.

After discussion on IRC, removed flex=1 and hidden=false from copy that got checked in as they were unneeded.
--> Fixed